fix: Show something to account for empty strings#656
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
Ive still yet to diagnose what events are failing to render, but its a better experience with some kind of placeholder.
|
dcramer
force-pushed
the
fix/empty-strings
branch
from
2f17fd6 to
5c7a3ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 31.43% 31.43%
=======================================
Files 92 92
Lines 5433 5433
Branches 100 100
=======================================
Hits 1708 1708
Misses 3725 3725 ☔ View full report in Codecov by Sentry. |
BYK
approved these changes
Jan 16, 2025
This was referenced Jan 22, 2025
BYK
pushed a commit
that referenced
this pull request
Jan 22, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/astro@2.4.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Updated dependencies \[[`5d8c7058300b349cd17d543874cfb810ff7db8d9`](5d8c705), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/spotlight@2.10.0 ## @spotlightjs/electron@1.4.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) - Updated dependencies \[[`8bed105e28f11c139c00f6b4a63717b1fb99d396`](8bed105), [`4c1b619079d4a1ca0e280dedef89bb8e1bf3f069`](4c1b619), [`9606eb25434468bb9377569667f4071a177b85ab`](9606eb2), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`277bd766aead9a6eabf043cc2490f59d0e1729b6`](277bd76), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/overlay@2.10.0 - @spotlightjs/sidecar@1.11.0 ## @spotlightjs/overlay@2.10.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) - Add base64 encoding for envelope passing ([#659](#659)) This fixes the issue certain characters getting lost or changed during the implicit and forced UTF-8 encoding, namely certain ANSI-escape characters when we capture them as breadcrumbs. This was breaking NextJS recently. The mechanism is opt-in from Sidecar side and the new overlay automatically opts in to fix the issue. The new overlay is also capable of processing messages w/o base64 encoding so this change is both backwards and forwards compatible meaning a new version of overlay can work with an old sidecar and a new version of sidecar can work with an older overlay. That said to get the fix, both should be on the new version, opting into base64 encoding. ### Patch Changes - Fix direct transport init when sidecar transport is already enabled ([#658](#658)) - Add auto-reload dev mode for Overlay ([#657](#657)) - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) ## @spotlightjs/sidecar@1.11.0 ### Minor Changes - Add base64 encoding for envelope passing ([#659](#659)) This fixes the issue certain characters getting lost or changed during the implicit and forced UTF-8 encoding, namely certain ANSI-escape characters when we capture them as breadcrumbs. This was breaking NextJS recently. The mechanism is opt-in from Sidecar side and the new overlay automatically opts in to fix the issue. The new overlay is also capable of processing messages w/o base64 encoding so this change is both backwards and forwards compatible meaning a new version of overlay can work with an old sidecar and a new version of sidecar can work with an older overlay. That said to get the fix, both should be on the new version, opting into base64 encoding. ### Patch Changes - Upgrades source-map dependency to avoid mappings.wasm error ([#638](#638)) ## @spotlightjs/spotlight@2.10.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Remove Windows home directories from Sentry reports ([#644](#644)) - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) - Updated dependencies \[[`8bed105e28f11c139c00f6b4a63717b1fb99d396`](8bed105), [`4c1b619079d4a1ca0e280dedef89bb8e1bf3f069`](4c1b619), [`9606eb25434468bb9377569667f4071a177b85ab`](9606eb2), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`277bd766aead9a6eabf043cc2490f59d0e1729b6`](277bd76), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/overlay@2.10.0 - @spotlightjs/sidecar@1.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dcramer
added a commit
that referenced
this pull request
Jun 3, 2025
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/astro@2.4.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Updated dependencies \[[`5d8c7058300b349cd17d543874cfb810ff7db8d9`](5d8c705), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/spotlight@2.10.0 ## @spotlightjs/electron@1.4.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) - Updated dependencies \[[`8bed105e28f11c139c00f6b4a63717b1fb99d396`](8bed105), [`4c1b619079d4a1ca0e280dedef89bb8e1bf3f069`](4c1b619), [`9606eb25434468bb9377569667f4071a177b85ab`](9606eb2), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`277bd766aead9a6eabf043cc2490f59d0e1729b6`](277bd76), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/overlay@2.10.0 - @spotlightjs/sidecar@1.11.0 ## @spotlightjs/overlay@2.10.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) - Add base64 encoding for envelope passing ([#659](#659)) This fixes the issue certain characters getting lost or changed during the implicit and forced UTF-8 encoding, namely certain ANSI-escape characters when we capture them as breadcrumbs. This was breaking NextJS recently. The mechanism is opt-in from Sidecar side and the new overlay automatically opts in to fix the issue. The new overlay is also capable of processing messages w/o base64 encoding so this change is both backwards and forwards compatible meaning a new version of overlay can work with an old sidecar and a new version of sidecar can work with an older overlay. That said to get the fix, both should be on the new version, opting into base64 encoding. ### Patch Changes - Fix direct transport init when sidecar transport is already enabled ([#658](#658)) - Add auto-reload dev mode for Overlay ([#657](#657)) - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) ## @spotlightjs/sidecar@1.11.0 ### Minor Changes - Add base64 encoding for envelope passing ([#659](#659)) This fixes the issue certain characters getting lost or changed during the implicit and forced UTF-8 encoding, namely certain ANSI-escape characters when we capture them as breadcrumbs. This was breaking NextJS recently. The mechanism is opt-in from Sidecar side and the new overlay automatically opts in to fix the issue. The new overlay is also capable of processing messages w/o base64 encoding so this change is both backwards and forwards compatible meaning a new version of overlay can work with an old sidecar and a new version of sidecar can work with an older overlay. That said to get the fix, both should be on the new version, opting into base64 encoding. ### Patch Changes - Upgrades source-map dependency to avoid mappings.wasm error ([#638](#638)) ## @spotlightjs/spotlight@2.10.0 ### Minor Changes - Render placeholders when missing known attributes in Sentry events ([#656](#656)) ### Patch Changes - Remove Windows home directories from Sentry reports ([#644](#644)) - Add `spotlight@` prefix to Sentry releases to distinguish them ([#660](#660)) - Updated dependencies \[[`8bed105e28f11c139c00f6b4a63717b1fb99d396`](8bed105), [`4c1b619079d4a1ca0e280dedef89bb8e1bf3f069`](4c1b619), [`9606eb25434468bb9377569667f4071a177b85ab`](9606eb2), [`cfa9cc967da8aa862f55c3880aab44f7d5b5eeb4`](cfa9cc9), [`277bd766aead9a6eabf043cc2490f59d0e1729b6`](277bd76), [`356890c6faf4ef3d9ebf85615e3f43f34fca0439`](356890c)]: - @spotlightjs/overlay@2.10.0 - @spotlightjs/sidecar@1.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.